[dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP crypto PMD

[Kumar, Ravi1]

>Hi Ravi,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ravi Kumar
>> Sent: Thursday, November 30, 2017 1:12 PM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP 
>> crypto PMD
>> 
>
>As I said in the another patch, you should add a commit message for complex patches like this one.
>Another thing that would be useful for improving the readability of the patchset and therefore, make a review easier, is to split a long patch in smaller patches.
>
>From what I have seen, you have some patches where you are adding support for CMAC and SHA3 algorithms. I suggest to do the same for the other algorithms that this PMD supports.
>So, the first patch would have the skeleton of the PMD, and then you can have a separate patch per algorithm.
>Well, not necessarily, a patch per algorithm, but per subset of algorithms.
>I would propose one for AES-CBC/ECB/CTR, one for 3DES-CBC, one for AES-GCM and another one for SHA-x algorithms.
>
>Thanks,
>Pablo
>
Hi Pablo,

Thanks for all the comments. We are working on them.

Regards,
Ravi