[dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag
Bruce Richardson
bruce.richardson at intel.com
Mon Dec 18 16:52:17 CET 2017
On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> ---
> GNUmakefile | 29 +----------------------------
> Makefile | 29 +----------------------------
> 2 files changed, 2 insertions(+), 56 deletions(-)
>
> diff --git a/GNUmakefile b/GNUmakefile
> index 45b7fbb..2ff3e4b 100644
> --- a/GNUmakefile
> +++ b/GNUmakefile
> @@ -1,33 +1,6 @@
> -# BSD LICENSE
> +# SPDX-License-Identifier: BSD-3-Clause
> #
> # Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
Actually, minor comment, can we remove the blank line between the SPDX
identifier and the copyright? Given that in the majority of cases, we
will only have one line each, having a space between them is a) probably
unnecessary, and b) looks weird IMHO.
I'm currently working on a patchset to update the meson.build files, and
I think having:
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
looks better as a header than two one-line paragraphs.
/Bruce
More information about the dev
mailing list