[dpdk-dev] [PATCH] net/pcap: convert license headers to SPDX tags

Hemant Agrawal hemant.agrawal at nxp.com
Tue Dec 19 06:02:51 CET 2017


HI Ferruh,

On 12/19/2017 2:48 AM, Ferruh Yigit wrote:
> On 12/18/2017 1:06 PM, Ferruh Yigit wrote:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>
> <...>
>
>> + * SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
>> + * Copyright(c) 2014 6WIND S.A.
>> + * All rights reserved.
>>   */
>
> Hi Hemant, Thomas,
>
> Can you please suggest about extra "All rights reserved." line.
>
> It is in the part of the BSD header, and I _assume_ that has been intended to
> cover all "Copyright" lines above it.
> But since some of the Copyright holders (at least Intel ones) already has that
> in same line with copyright and I _assume_ this is intentional because of legal
> requirements, can we remove that line.
>
> I guess we have two options while removing it, applying it to all previous
> Copyright lines (B) or just remove it (A):
>
> (A)
>  SPDX-License-Identifier: BSD-3-Clause
>  Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
>  Copyright(c) 2014 6WIND S.A.
>
> (B)
>  SPDX-License-Identifier: BSD-3-Clause
>  Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
>  Copyright(c) 2014 6WIND S.A. All rights reserved.
>
>
> Can we go with option (A)?
>

"All rights reserved" depend on legal counsel.
e.g Freescale preferred it, with NXP migration, we have stopped doing it.

w.r.t your query, I will suggest option (c)
SPDX-License-Identifier: BSD-3-Clause
Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
Copyright(c) 2014 6WIND S.A.
All rights reserved.

i.e no change in copyright.

However, as Bruce mentioned, we can remove *All rights reserved*  for 
the files having duplicate statement for a single copyright.


More information about the dev mailing list