[dpdk-dev] [PATCH 07/13] examples/eventdev: add thread safe Tx worker pipeline

[Van Haaren, Harry]

> From: Pavan Nikhilesh [mailto:pbhagavatula at caviumnetworks.com]
> Sent: Thursday, December 7, 2017 8:37 PM
> To: Eads, Gage <gage.eads at intel.com>; jerin.jacobkollanukkaran at cavium.com;
> Van Haaren, Harry <harry.van.haaren at intel.com>; Rao, Nikhil
> <nikhil.rao at intel.com>; hemant.agrawal at nxp.com; Ma, Liang J
> <liang.j.ma at intel.com>
> Cc: dev at dpdk.org; Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
> Subject: [PATCH 07/13] examples/eventdev: add thread safe Tx worker pipeline
> 
> Add worker pipeline when Tx is multi thread safe.
> Probe Ethernet dev capabilities and select it it is supported.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>

<snip>

>  static void
> diff --git a/examples/eventdev_pipeline_sw_pmd/pipeline_common.h
> b/examples/eventdev_pipeline_sw_pmd/pipeline_common.h
> index a5837c99b..0b27d1eb0 100644
> --- a/examples/eventdev_pipeline_sw_pmd/pipeline_common.h
> +++ b/examples/eventdev_pipeline_sw_pmd/pipeline_common.h
> @@ -108,6 +108,7 @@ struct config_data {
>  	int dump_dev_signal;
>  	unsigned int num_stages;
>  	unsigned int worker_cq_depth;
> +	unsigned int rx_stride;

Perhaps comment what "rx stride" does? The others variables are logical enough to me, but this one I don't get.. 

> +static int
> +setup_eventdev_w(struct prod_data *prod_data,
> +		struct cons_data *cons_data,
> +		struct worker_data *worker_data)

I think this function name can be improved - what does the w mean?