[dpdk-dev] [PATCH] net/pcap: convert license headers to SPDX tags

Bruce Richardson bruce.richardson at intel.com
Tue Dec 19 20:41:22 CET 2017


On Tue, Dec 19, 2017 at 11:29:25AM -0800, Ferruh Yigit wrote:
> On 12/19/2017 2:18 AM, Bruce Richardson wrote:
> > On Mon, Dec 18, 2017 at 01:18:33PM -0800, Ferruh Yigit wrote:
> >> On 12/18/2017 1:06 PM, Ferruh Yigit wrote:
> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> >>
> >> <...>
> >>
> >>> + * SPDX-License-Identifier: BSD-3-Clause
> >>> + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> >>> + * Copyright(c) 2014 6WIND S.A.
> >>> + * All rights reserved.
> >>>   */
> >>
> >> Hi Hemant, Thomas,
> >>
> >> Can you please suggest about extra "All rights reserved." line.
> >>
> >> It is in the part of the BSD header, and I _assume_ that has been intended to
> >> cover all "Copyright" lines above it.
> >> But since some of the Copyright holders (at least Intel ones) already has that
> >> in same line with copyright and I _assume_ this is intentional because of legal
> >> requirements, can we remove that line.
> >>
> >> I guess we have two options while removing it, applying it to all previous
> >> Copyright lines (B) or just remove it (A):
> >>
> >> (A)
> >>  SPDX-License-Identifier: BSD-3-Clause
> >>  Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> >>  Copyright(c) 2014 6WIND S.A.
> >>
> >> (B)
> >>  SPDX-License-Identifier: BSD-3-Clause
> >>  Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> >>  Copyright(c) 2014 6WIND S.A. All rights reserved.
> >>
> >>
> >> Can we go with option (A)?
> > 
> > Hi Ferruh,
> > 
> > I'm looking to replace a lot of the Intel-copyright license headers -
> > automating it right now. The latest Intel template actually has the
> > "all rights reserved" omitted. [See my patch for meson.build files]
> 
> Batch update is good idea, thanks.
> If your patch doesn't cover this I update the patch to omit that part.
> 
My patches don't cover files with multiple copyright holders, so
additional patches here will be needed.

Thanks,
/Bruce


More information about the dev mailing list