[dpdk-dev] [PATCH] member: fix memory leak on error

Burakov, Anatoly anatoly.burakov at intel.com
Fri Dec 22 10:20:44 CET 2017


On 22-Dec-17 12:01 AM, Wang, Yipeng1 wrote:
> Thank you Anatoly for finding this issue. In the code I tried to reuse the rte_member_free function to free memory but it may not be executed through.
> 
> Because of this, I may not properly release setsum struct neither. I will post a fix for both soon.
> 
> Thanks

Yep, i can see that now. Didn't think to look inside rte_member_free() 
:/ However, you're creating a race condition there - you're unlocking a 
tailq, and then locking (and unlocking) it again inside 
rte_member_free() - it probably needs _thread_unsafe() functions that 
you can call from behind the lock.

-- 
Thanks,
Anatoly


More information about the dev mailing list