[dpdk-dev] [PATCH 1/2] mempool: indicate the usages of multi memzones

Hemant Agrawal hemant.agrawal at nxp.com
Fri Dec 22 17:18:01 CET 2017


On 12/22/2017 7:29 PM, Olivier MATZ wrote:
> On Wed, Dec 20, 2017 at 05:29:59PM +0530, Hemant Agrawal wrote:
>> On 12/19/2017 6:38 PM, Hemant Agrawal wrote:
>>>
>>>> That's true, I commented too fast :)
>>>> And what about using mp->nb_mem_chunks instead? Would it do the job
>>>> in your use-case?
>>>
>>> It should work.  Let me check it out.
>>
>> There is a slight problem with nb_mem_chunks.
>>
>> It is getting incremented in the end of "rte_mempool_populate_phys",
>> while the elements are getting populated before it in the call of
>> mempool_add_elem.
>>
>> I can use nb_mem_chunks are '0' check. However it can break in future if
>> mempool_populate_phys changes.
>
> Sorry, I'm not sure I'm getting what you say.
>
> My question was about using mp->nb_mem_chunks instead of a new flag in the
> dppa driver. Am I missing something?
>

mp->nb_mem_chunks gets finalized when the mempool is fully created. It's 
value is transient before that i.e. it will keep on changing on the 
every call to rte_mempool_populate_phys.

However, we need this information on the very first element allocation. 
So, nb_mem_chunks will not work.


More information about the dev mailing list