[dpdk-dev] [PATCH v2] bus/pci: fix wrong intr_handle.type with uio_pci_generic

Zhiyong Yang zhiyong.yang at intel.com
Fri Dec 29 08:55:11 CET 2017


For virtio legacy device, testpmd startup fails when using
uio_pci_generic. The issue is caused by invoking the function
pci_ioport_map. The right intr_handle.type is already set before
calling it, we should avoid overwriting the default value "RTE_
INTR_HANDLE_UNKNOWN" in it. Besides, the removal has no harm to
other cases since it already is set to this value (0) at init.

Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API")
Cc: stable at dpdk.org
Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>
---

Changes in V2:
1. reword the commit log.
2. remove the assignment operation which causes the issue.

 drivers/bus/pci/linux/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 5da6728fb..ec31216bc 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -723,7 +723,6 @@ pci_ioport_map(struct rte_pci_device *dev, int bar __rte_unused,
 	if (!found)
 		return -1;
 
-	dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;
 	p->base = start;
 	RTE_LOG(DEBUG, EAL, "PCI Port IO found start=0x%x\n", start);
 
-- 
2.13.3



More information about the dev mailing list