[dpdk-dev] [PATCH v1] service: fix memory leak by rte_service_init

[Vipin Varghese]

This patch fixes the memory leak created by rte_service_init, when
run from secondary application. Running secondary application which
shares the huge page memory from primary multiple times causes memory
to be initialized but not free when application exit.

The rte_service_deinit check if the service is initialized. If yes, it
frees up rte_services & lcore_states. The API has to be called at end of
application run.

Signed-off-by: Vipin Varghese <vipin.varghese at intel.com>
---
 lib/librte_eal/common/include/rte_service.h |  9 +++++++++
 lib/librte_eal/common/rte_service.c         | 14 ++++++++++++++
 lib/librte_eal/rte_eal_version.map          |  1 +
 3 files changed, 24 insertions(+)

diff --git a/lib/librte_eal/common/include/rte_service.h b/lib/librte_eal/common/include/rte_service.h
index 9272440..ad2649e 100644
--- a/lib/librte_eal/common/include/rte_service.h
+++ b/lib/librte_eal/common/include/rte_service.h
@@ -420,6 +420,15 @@ int32_t rte_service_run_iter_on_app_lcore(uint32_t id,
  */
 int32_t rte_service_dump(FILE *f, uint32_t id);
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
+ * Fress all memory that is internally used.
+ */
+
+void rte_service_deinit(void);
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index ae97e6b..017bc67 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -98,6 +98,20 @@ struct core_state {
 static struct core_state *lcore_states;
 static uint32_t rte_service_library_initialized;
 
+void rte_service_deinit(void)
+{
+	if (rte_service_library_initialized) {
+		if (rte_services)
+			rte_free(rte_services);
+		if (lcore_states)
+			rte_free(lcore_states);
+
+		rte_service_library_initialized = 0;
+	}
+	return;
+}
+
+
 int32_t rte_service_init(void)
 {
 	if (rte_service_library_initialized) {
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index f4f46c1..0f14409 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -234,5 +234,6 @@ EXPERIMENTAL {
 	rte_service_set_runstate_mapped_check;
 	rte_service_set_stats_enable;
 	rte_service_start_with_defaults;
+	rte_service_deinit;
 
 } DPDK_17.11;
-- 
1.9.1