[dpdk-dev] [PATCH] net/ixgbe: output details on failure to configure filter
Stephen Hemminger
stephen at networkplumber.org
Sat Feb 4 22:50:58 CET 2017
On Sat, 4 Feb 2017 16:37:54 +0800
Wei Dai <wei.dai at intel.com> wrote:
> + PMD_INIT_LOG(ERR, "If ixgbe MAC type is not X550 or X550EM_x or "
> + "X550EM_a, the filter mode must be signature or perfect, other mode "
> + "is not supported ! Current MAC type = %d filter mode = %d",
> + (int)(hw->mac.type), (int)mode);
> return -ENOSYS;
Having better messages is good. Please punctuate correctly, and ! is not necessary.
Please try and keep it to one line, having really long log messages doesn't help.
Also, breaking a string makes it harder to use grep to find the source.
More information about the dev
mailing list