[dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags

[Ananyev, Konstantin]

Hi Jingjing,


> -----Original Message-----
> From: Wu, Jingjing
> Sent: Saturday, February 4, 2017 3:36 AM
> To: dev at dpdk.org
> Cc: Wu, Jingjing <jingjing.wu at intel.com>; Ananyev, Konstantin <konstantin.ananyev at intel.com>
> Subject: [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags
> 
> Add missed flags to bitmask of all supported packet Tx flags.
> 
> CC: konstantin.ananyev at intel.com
> Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation")
> Signed-off-by: Jingjing Wu <jingjing.wu at intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_rxtx.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 36f1c02..8454581 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -81,13 +81,28 @@
>  #include "ixgbe_rxtx.h"
> 
>  /* Bit Mask to indicate what bits required for building TX context */
> +#ifdef RTE_LIBRTE_IEEE1588
>  #define IXGBE_TX_OFFLOAD_MASK (			 \
>  		PKT_TX_VLAN_PKT |		 \
>  		PKT_TX_IP_CKSUM |		 \
> +		PKT_TX_IPV4 |			 \
>  		PKT_TX_L4_MASK |		 \
> +		PKT_TX_IEEE1588_TMST |		 \
>  		PKT_TX_TCP_SEG |		 \
>  		PKT_TX_MACSEC |			 \
> -		PKT_TX_OUTER_IP_CKSUM)
> +		PKT_TX_OUTER_IP_CKSUM |		 \
> +		PKT_TX_OUTER_IPV4)
> +#else
> +#define IXGBE_TX_OFFLOAD_MASK (			 \
> +		PKT_TX_VLAN_PKT |		 \
> +		PKT_TX_IP_CKSUM |		 \
> +		PKT_TX_IPV4 |			 \

Wonder why ixgbe doesn't have PKT_TX_IPV6?
Konstantin

> +		PKT_TX_L4_MASK |		 \
> +		PKT_TX_TCP_SEG |		 \
> +		PKT_TX_MACSEC |			 \
> +		PKT_TX_OUTER_IP_CKSUM |		 \
> +		PKT_TX_OUTER_IPV4)
> +#endif
> 
>  #define IXGBE_TX_OFFLOAD_NOTSUP_MASK \
>  		(PKT_TX_OFFLOAD_MASK ^ IXGBE_TX_OFFLOAD_MASK)
> --
> 2.4.11