[dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

Dai, Wei wei.dai at intel.com
Thu Feb 9 15:50:05 CET 2017


Another way is to clear hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_vfmprc 
at the same time PF is set down.

> -----Original Message-----
> From: Dai, Wei
> Sent: Thursday, February 9, 2017 10:38 PM
> To: 'Olivier Matz' <olivier.matz at 6wind.com>; dev at dpdk.org; Zhang, Helin
> <helin.zhang at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>
> Cc: Guo Fengtian <fengtian.guo at 6wind.com>; stable at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset
> 
> The stats register can rewind to zero when the port is running for a long period.
> So I am afraid that this check is not always correct.
> Why not introduce a variable to directly indicate whether the resulted stats
> should be updated or not.
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz
> > Sent: Monday, February 6, 2017 9:59 PM
> > To: dev at dpdk.org; Zhang, Helin <helin.zhang at intel.com>; Ananyev,
> > Konstantin <konstantin.ananyev at intel.com>
> > Cc: Guo Fengtian <fengtian.guo at 6wind.com>; stable at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a
> > PF reset
> >
> > Hi,
> >
> > On Wed, 11 Jan 2017 18:04:14 +0100, Olivier Matz
> > <olivier.matz at 6wind.com>
> > wrote:
> > > From: Guo Fengtian <fengtian.guo at 6wind.com>
> > >
> > > When PF is set down, in VF, the value of stats register is zero.
> > > So only increase stats when it's non zero.
> > >
> > > Fixes: af75078fece3 ("first public release")
> > >
> > > CC: stable at dpdk.org
> > > Signed-off-by: Guo Fengtian <fengtian.guo at 6wind.com>
> > > Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
> >
> > Ping
> >
> >
> > Thanks,
> > Olivier


More information about the dev mailing list