[dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL

Shreyansh Jain shreyansh.jain at nxp.com
Tue Feb 14 06:18:39 CET 2017


On Tuesday 14 February 2017 03:26 AM, Jan Blunck wrote:
> On Mon, Feb 13, 2017 at 1:00 PM, Shreyansh Jain <shreyansh.jain at nxp.com> wrote:
>> On Monday 13 February 2017 05:25 PM, Shreyansh Jain wrote:
>>>
>>> EAL PCI layer is planned to be restructured in 17.05 to unlink it from
>>> generic structures like eth_driver, rte_cryptodev_driver, and also move
>>> it into a PCI Bus.
>>>
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
>>> ---
>>>  doc/guides/rel_notes/deprecation.rst | 12 ++++++++----
>>>  1 file changed, 8 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst
>>> b/doc/guides/rel_notes/deprecation.rst
>>> index fbe2fcb..b12d435 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -13,10 +13,14 @@ Deprecation Notices
>>>    has exposed, like the way we have done with uio-pci-generic. This
>>> change
>>>    targets release 17.05.
>>>
>>> -* ``eth_driver`` is planned to be removed in 17.02. This currently serves
>>> as
>>> -  a placeholder for PMDs to register themselves. Changes for ``rte_bus``
>>> will
>>> -  provide a way to handle device initialization currently being done in
>>> -  ``eth_driver``.
>>
>>
>> Just to highlight, above statement was added by me in 16.11.
>> As of now I plan to work on removing rte_pci_driver from eth_driver,
>> rather than removing eth_driver all together (which, probably, was
>> better idea).
>> If someone still wishes to work on its complete removal, we can keep
>> the above. (and probably remove the below).
>>
>
> There is no benefit in keeping eth_driver and removing rte_pci_driver
> from it. Technically it isn't even needed today.

I agree with you.
I stopped working on it because I realized that removing it means making
pci_probe call eth_dev_init handlers directly. Or, restructure the whole
of pci probe stack - which, because of pending PCI bus implementation,
was slightly tentative.

Changes are already expected in EAL PCI code for bus movement, probably
this task can be combined with that.

>
>>
>>> +* ABI/API changes are planned for 17.05 for PCI subsystem. This is to
>>> +  unlink EAL dependency on PCI and to move PCI devices to a PCI specific
>>> +  bus.
>>> +
>>> +* ``rte_pci_driver`` is planned to be removed from ``eth_driver`` in
>>> 17.05.
>>> +  This is to unlink the ethernet driver from PCI dependencies.
>>> +  Similarly, ``rte_pci_driver`` in planned to be removed from
>>> +  ``rte_cryptodev_driver`` in 17.05.
>>>
>>>  * In 17.02 ABI changes are planned: the ``rte_eth_dev`` structure will be
>>>    extended with new function pointer ``tx_pkt_prepare`` allowing
>>> verification
>>>
>>
>



More information about the dev mailing list