[dpdk-dev] [RFC 17.05] test: move tests to separate folder

[Wiles, Keith]

> On Feb 14, 2017, at 9:41 AM, Bruce Richardson <bruce.richardson at intel.com> wrote:
> 
> On Tue, Feb 14, 2017 at 03:13:26PM +0000, Ferruh Yigit wrote:
>> Tests are part of app folder and compiled with library every time.
>> Moving tests into a "test" folder which won't be compiled by default.
>> To compile tests, need to give explicit "make test" command.
>> 
>> "make test" was previously used to run tests, which renamed to
>> "make test_run" with this patch.
>> 
>> This makes default compilation ~30% faster,
>> [clang, make -j8, old]: real    1m04.355s
>> [clang, make -j8, new]: real    0m41.740s
>> 
>> For new case, test needs to built separately, which takes,
>> [clang, make -j8 test]: real    0m24.293s
>> 
>> The point is tests are not required always and by every one.
>> 
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>> ---
> 
> Hi Ferruh,
> 
> I'm not sure I'm convinced by this, as I think there are advantages to
> having the test code always compiled. Anything that is not compiled in
> DPDK by default is more likely to be broken by patch submissions. The
> speed boost to build is nice, but I'm not sure it's worth it.
> However, I'm open to being convinced otherwise on this...
> 
> /Bruce

I am kind of in the same boat as Bruce on the tests, but I was thinking the other applications in the app directory pretty much use most of the APIs, right? If that is the case then I would agree with Ferruh.

Regards,
Keith