[dpdk-dev] [PATCH 2/2] net/mlx4: support basic flow items and actions
Nélio Laranjeiro
nelio.laranjeiro at 6wind.com
Wed Feb 22 11:10:01 CET 2017
On Wed, Feb 22, 2017 at 09:37:42AM +0100, Nélio Laranjeiro wrote:
> On Tue, Feb 21, 2017 at 02:07:03PM +0000, Vasily Philipov wrote:
> > Adding support for the next items: eth, vlan, ipv4, udp, tcp and for the
> > next actions: queue, drop
> >
> > Signed-off-by: Vasily Philipov <vasilyf at mellanox.com>
> > ---
> > drivers/net/mlx4/Makefile | 3 +-
> > drivers/net/mlx4/mlx4.c | 60 ++-
> > drivers/net/mlx4/mlx4.h | 3 +
> > drivers/net/mlx4/mlx4_flow.c | 1053 ++++++++++++++++++++++++++++++++++++++++++
> > drivers/net/mlx4/mlx4_flow.h | 104 +++++
> > 5 files changed, 1220 insertions(+), 3 deletions(-)
> > create mode 100644 drivers/net/mlx4/mlx4_flow.c
> > create mode 100644 drivers/net/mlx4/mlx4_flow.h
> >
>[...]
> > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> > index 82ccac8..cc2ebfa 100644
> > --- a/drivers/net/mlx4/mlx4.c
> > +++ b/drivers/net/mlx4/mlx4.c
> > @@ -3985,8 +3989,9 @@ struct txq_mp2mr_mbuf_check_data {
> > return -ret;
> > } while ((--r) && ((rxq = (*priv->rxqs)[++i]), i));
> > priv_dev_interrupt_handler_install(priv, dev);
> > + err = mlx4_priv_flow_start(priv);
> > priv_unlock(priv);
> > - return 0;
> > + return -err;
>[...]
Hi Vasily,
There is an issue in this mlx4_dev_start() when flows cannot be
re-applied (like in mlx5 [1][2]). Can you fix it in a v2 please?
Thanks,
[1] http://dpdk.org/ml/archives/dev/2017-February/058111.html
[2] http://dpdk.org/dev/patchwork/patch/20664/
--
Nélio Laranjeiro
6WIND
More information about the dev
mailing list