[dpdk-dev] [PATCH v7 15/17] lib: make v20 header file private

Bruce Richardson bruce.richardson at intel.com
Fri Feb 24 15:18:33 CET 2017


On Tue, Feb 21, 2017 at 03:17:51AM +0000, David Hunt wrote:
> Signed-off-by: David Hunt <david.hunt at intel.com>
> ---
>  lib/librte_distributor/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile
> index 5b599c6..3017398 100644
> --- a/lib/librte_distributor/Makefile
> +++ b/lib/librte_distributor/Makefile
> @@ -53,8 +53,7 @@ endif
>  
>  
>  # install this header file
> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor_v20.h
> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor.h
> +SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h
>  

Minor nits:
1/ I think this patch should go earlier in the set.
2/ you can keep the += in the assignment. It actually makes it less
error prone for anyone changing/adding things later as they can
copy-paste or reorder the lines without causing themselves problems.

/Bruce



More information about the dev mailing list