[dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions

Bruce Richardson bruce.richardson at intel.com
Tue Feb 28 11:27:01 CET 2017


On Mon, Feb 27, 2017 at 05:06:24PM +0000, Legacy, Allain wrote:
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> > On Sun, 26 Feb 2017 14:08:59 -0500
> > Allain Legacy <allain.legacy at windriver.com> wrote:
> > 
> > Try not to break error messages onto two lines, it makes it harder when a
> > user is trying to find the location of the error message with search tools
> That's our normal practice, but checkpatches.sh flagged them as warnings.   If these are acceptable exceptions to the tool then are there plans to publish an exhaustive list of checkpatches.sh errors/warnings/checks that can be ignored?  Alternatively, are there plans to change the tools to ignore these automatically and not flag them as issues.   As a contributor it is difficult to tell what will be deemed acceptable and what will not (in some cases) so the default position is to fix all issues before submission. 
>
In my experience, checkpatch ignores long lines that are due to error
messages. Perhaps you need to put the error message on a separate line,
if other things before the message are of significant size.

/Bruce


More information about the dev mailing list