[dpdk-dev] [PATCH v3] ethtool: dispaly bus info and firmware version
Wu, Jingjing
jingjing.wu at intel.com
Wed Jan 4 08:51:44 CET 2017
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiming Yang
> Sent: Tuesday, December 27, 2016 9:06 PM
> To: dev at dpdk.org; thomas.monjalon at 6wind.com
> Cc: Horton, Remy <remy.horton at intel.com>; Yigit, Ferruh
> <ferruh.yigit at intel.com>; Yang, Qiming <qiming.yang at intel.com>
> Subject: [dpdk-dev] [PATCH v3] ethtool: dispaly bus info and firmware version
>
> This patch enhances the ethtool example to support to show bus information
> and firmware version, in the same way that the Linux kernel ethtool does.
>
> Signed-off-by: Qiming Yang <qiming.yang at intel.com>
> ---
> v3 changes:
> * split this patch from the patch set of rte_eth_dev_fw_info_get
> use the new version function.
> ---
> ---
> examples/ethtool/ethtool-app/ethapp.c | 2 ++
> examples/ethtool/lib/rte_ethtool.c | 11 +++++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/examples/ethtool/ethtool-app/ethapp.c
> b/examples/ethtool/ethtool-app/ethapp.c
> index 6aeaa06..192d941 100644
> --- a/examples/ethtool/ethtool-app/ethapp.c
> +++ b/examples/ethtool/ethtool-app/ethapp.c
> @@ -185,6 +185,8 @@ pcmd_drvinfo_callback(__rte_unused void *ptr_params,
> printf("Port %i driver: %s (ver: %s)\n",
> id_port, info.driver, info.version
> );
> + printf("bus-info: %s\n", info.bus_info);
This patch has dependence on your get_fw_version patch set.
I think you may misunderstand Ferruh's comments,
I think what he said was ask you to remove bus-info print (above line) from that patch set,
but keep firmware version print.
Thanks
Jingjing
More information about the dev
mailing list