[dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes
Rasesh.Mody at cavium.com
Thu Jan 5 08:16:16 CET 2017
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Tuesday, January 03, 2017 7:41 AM
> On 12/31/2016 7:41 AM, Mody, Rasesh wrote:
> >> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> >> Sent: Friday, December 23, 2016 7:42 AM
> >> On 12/3/2016 9:11 AM, Rasesh Mody wrote:
> >>> This patch consists of semantic/formatting changes. It also includes
> >>> comment additions.
> >> As far as I can see majority of the changes are formatting, but not all.
> >> Functional changes are hard to detect in this patch, what do you
> >> think separating formatting/comments patches into another patch, so
> >> functional changes can become more visible?
> > There are few of places(ecore_hw_bar_size(), ecore_get_hw_info() and
> ecore_init_cmd_*), where there is a bit of code refactoring. However, they
> are not a major change. We have tried to isolate most of the functional
> changes and made them part of the separate patches as fit. I think, we can
> include a bit of description in commit message to cover it in this patch. Please
> let me know if you think otherwise.
> I believe it is good to separate code refactoring into different patch if
> possible, instead of covering this in commit log.
> This makes functional changes easy to find in the future. In this patch hard to
> spot them.
V2 series has been submitted to separate code refactoring changes and address few other comments received for this patch set.
> >>> Signed-off-by: Rasesh Mody <Rasesh.Mody at cavium.com>
> >>> ---
> >> <...>
More information about the dev