[dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.
yongwang at vmware.com
Fri Jan 6 01:01:48 CET 2017
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Thursday, January 5, 2017 6:24 AM
> To: nickcooper-zhangtonghao <nic at opencloud.tech>; dev at dpdk.org; Yong
> Wang <yongwang at vmware.com>
> Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system
> which not support NUMA.
> On 1/5/2017 12:01 PM, nickcooper-zhangtonghao wrote:
> > The NUMA node information for PCI devices provided through
> > sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx
> > on Red Hat Enterprise Linux 6, and VMs on some hypervisors.
> > Signed-off-by: nickcooper-zhangtonghao <nic at opencloud.tech>
> Hi nickcooper-zhangtonghao,
> The patches in the patchset are individual patches, right? Is there any
> dependency between them?
> And CC'ed vmxnet3 driver maintainer: Yong Wang <yongwang at vmware.com>
Can you add the exact steps to reproduce the vmxnet3 issues to help the review and the verification. My guess is that you have stopped the device, changed some ring parameters (to something larger than the previous settings) and restarted the device. Such info should be included into the commit description in addition to just saying what the patch does.
> > ---
> > lib/librte_eal/linuxapp/eal/eal_pci.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
> > index 4350134..5dfdbe9 100644
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> > @@ -317,7 +317,13 @@
> > free(dev);
> > return -1;
> > }
> > - dev->device.numa_node = tmp;
> > + /* The NUMA node information for PCI devices provided
> > + * sysfs is invalid for AMD Opteron(TM) Processor 62xx and
> > + * on Red Hat Enterprise Linux 6, and VMs on some
> > + * In the upstream linux kernel, the numa_node is an integer,
> > + * which data type is int, not unsigned long.
> > + */
> > + dev->device.numa_node = (int)tmp > 0 ? (int)tmp : 0;
> > }
> > /* parse resources */
More information about the dev