[dpdk-dev] [PATCH v7 17/27] net/i40e: set VF VLAN filter from PF
Iremonger, Bernard
bernard.iremonger at intel.com
Fri Jan 6 12:38:25 CET 2017
Hi Jinqjing,
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Friday, January 6, 2017 12:37 AM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; dev at dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger at intel.com>
> Subject: RE: [dpdk-dev] [PATCH v7 17/27] net/i40e: set VF VLAN filter from
> PF
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Tuesday, January 3, 2017 2:55 PM
> > To: dev at dpdk.org
> > Cc: Iremonger, Bernard <bernard.iremonger at intel.com>
> > Subject: [dpdk-dev] [PATCH v7 17/27] net/i40e: set VF VLAN filter from
> > PF
> >
> > From: Bernard Iremonger <bernard.iremonger at intel.com>
> >
> > add rte_pmd_i40e_set_vf_vlan_filter API.
> > User can call the API on PF to enable/disable a set of VF's VLAN filters.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 52
> > +++++++++++++++++++++++++++++++
> > drivers/net/i40e/rte_pmd_i40e.h | 22 +++++++++++++
> > drivers/net/i40e/rte_pmd_i40e_version.map | 1 +
> > 3 files changed, 75 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 4d2fb20..47e03d6 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -10428,3 +10428,55 @@ int rte_pmd_i40e_set_vf_vlan_tag(uint8_t
> > port, uint16_t vf_id, uint8_t on)
> >
> > return ret;
> > }
> > +
> > +int rte_pmd_i40e_set_vf_vlan_filter(uint8_t port, uint16_t vlan_id,
> > + uint64_t vf_mask, uint8_t on) {
> > + struct rte_eth_dev *dev;
> > + struct rte_eth_dev_info dev_info;
> > + struct i40e_pf *pf;
> > + uint16_t pool_idx;
> > + int ret = I40E_SUCCESS;
> > +
> > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
> > +
> > + dev = &rte_eth_devices[port];
> > + rte_eth_dev_info_get(port, &dev_info);
> > +
> > + if (vlan_id > ETHER_MAX_VLAN_ID)
> > + return -EINVAL;
> > +
> > + if (on > 1)
> > + return -EINVAL;
> > +
> > + pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> > + if ((pf->flags & I40E_FLAG_VMDQ) == 0) {
> > + PMD_INIT_LOG(ERR, "Firmware doesn't support VMDQ");
> > + return -ENOTSUP;
> > + }
> > +
> > + if (!pf->vmdq) {
> > + PMD_INIT_LOG(INFO, "VMDQ not configured");
> > + return -ENOTSUP;
> > + }
> > +
> > + for (pool_idx = 0;
> > + pool_idx < ETH_64_POOLS &&
> > + pool_idx < pf->nb_cfg_vmdq_vsi &&
> > + ret == I40E_SUCCESS;
> > + pool_idx++) {
> > + if (vf_mask & ((uint64_t)(1ULL << pool_idx))) {
> > + if (on)
> > + ret = i40e_vsi_add_vlan(pf-
> >vmdq[pool_idx].vsi,
> > + vlan_id);
> > + else
> > + ret = i40e_vsi_delete_vlan(
> > + pf->vmdq[pool_idx].vsi, vlan_id);
> > + }
> > + }
>
> The head is saying "set VF VLAN filter", why do you deal with VMDQ VSIs?
This API is modelled on the rte_pmd_ixgbe_set_vf_vlan_filter(uint8_t port, uint16_t vlan_id, uint64_t vf_mask, uint8_t on) which seems to use VMDq. More investigation is needed here.
Regards,
Bernard.
More information about the dev
mailing list