[dpdk-dev] [PATCH v4 5/5] ethtool: dispaly firmware version

Remy Horton remy.horton at intel.com
Fri Jan 6 16:55:06 CET 2017

On 05/01/2017 01:31, Yang, Qiming wrote:
>> +	if (strcmp(drvinfo->driver, "net_ixgbe") == 0)
> Do you need this check. I think it is not good idea to add this kind
> of checks into ethtool app. Why not just print "%d.%d.%d %#X, major,
> minor, patch, etrack" for all cases ?
 > Qiming: because I want to keep the format same with kernel version 

My feeling is that if we're going to have driver-specific output, then 
the task of constructing the string should be pushed down into the PMDs. 
It would also solve the headache of trying to standardise, as Thomas has 


More information about the dev mailing list