[dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter
Zhao1, Wei
wei.zhao1 at intel.com
Tue Jan 10 06:46:58 CET 2017
Hi, Yigit
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, January 7, 2017 1:20 AM
> To: Zhao1, Wei <wei.zhao1 at intel.com>; dev at dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter
>
> On 12/30/2016 7:53 AM, Wei Zhao wrote:
> > check if the rule is a TCP SYN rule, and get the SYN info.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> >
> > ---
> >
> > v2:add new error set function
> > ---
>
> <...>
>
> > +static int
> > +ixgbe_parse_syn_filter(const struct rte_flow_attr *attr,
> > + const struct rte_flow_item pattern[],
> > + const struct rte_flow_action actions[],
> > + struct rte_eth_syn_filter *filter,
> > + struct rte_flow_error *error) {
> > + int ret;
> > +
> > + ret = cons_parse_syn_filter(attr, pattern,
> > + actions, filter, error);
> > +
>
> > + if (ret)
> > + return ret;
> > +
> > + return 0;
>
> "return ret;" will do the same.
> Or remove ret completely perhaps.
>
> > +}
> > +
> <...>
Yes, "return ret;" may be more appropriate.
More information about the dev
mailing list