[dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check

Declan Doherty declan.doherty at intel.com
Tue Jan 10 10:28:11 CET 2017


On 09/01/17 14:45, Piotr Azarewicz wrote:
> EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is
> unneeded.
>
> Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
>
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz at intel.com>
> ---
>  drivers/crypto/openssl/rte_openssl_pmd.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
> index 832ea1d..312154a 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
> @@ -522,8 +522,7 @@
>  	if (EVP_DecryptInit_ex(ctx, algo, NULL, key, iv) <= 0)
>  		goto process_cipher_decrypt_err;
>
> -	if (EVP_CIPHER_CTX_set_padding(ctx, 0) <= 0)
> -		goto process_cipher_decrypt_err;
> +	EVP_CIPHER_CTX_set_padding(ctx, 0);
>
>  	if (EVP_DecryptUpdate(ctx, dst, &dstlen, src, srclen) <= 0)
>  		goto process_cipher_decrypt_err;
>

Acked-by: Declan Doherty <declan.doherty at intel.com>


More information about the dev mailing list