[dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Jan 12 20:05:22 CET 2017


2017-01-12 15:30, Remy Horton:
> 
> On 12/01/2017 13:22, Thomas Monjalon wrote:
> > 2017-01-12 00:03, Remy Horton:
> [..]
> >> --- /dev/null
> >> +++ b/lib/librte_metrics/rte_metrics.h
> >> +/** Used to indicate port-independent information */
> >> +#define RTE_METRICS_NONPORT -1
> >
> > I do not understand this constant.
> > Why using the word "port" to name any device?
> > What means independent?
> 
> The metric library hold two sets of values: Ones specific to ports, and 
> ones that are global/aggregate. Agree "non port" is not the clearest 
> choice of name..

I think you should not use the word "port" at all.


More information about the dev mailing list