[dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

[Alejandro Lucero]

I was assuming in my acked answer, that the patch had followed usual path
and automatic compilation did not fail.

But I forgot about the NFP PMD not being enabled by default :-)

Hopefully, this will change if this just sent patch is accepted:

http://www.dpdk.org/ml/archives/dev/2017-January/054890.html

By other hand, I have compiled the NFP PMD with this patch and it works.

So acked again.

Thanks


On Fri, Jan 13, 2017 at 2:48 PM, Olivier Matz <olivier.matz at 6wind.com>
wrote:

> On Fri, 13 Jan 2017 13:17:17 +0000, Ferruh Yigit
> <ferruh.yigit at intel.com> wrote:
> > On 1/13/2017 12:48 PM, Olivier Matz wrote:
> > > On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
> > > <ferruh.yigit at intel.com> wrote:
> > >> On 1/12/2017 1:04 PM, Olivier Matz wrote:
> > >>> Fix typo when checking that no Vlan offload flags are passed at
> > >>> port initialization.
> > >>>
> > >>> By the way, also fix a typo in the log.
> > >>>
> > >>> Fixes: d4a27a3b092a ("nfp: add basic features")
> > >>>
> > >>> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
> > >>> ---
> >
> > <...>
> >
> > >
> > >
> > > I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.
> >
> > If this will be the only change, I can update it if you want:
> >
> > -   (mask & ETH_VLAN_FILTER_OFFLOAD))
> > -       RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD
> > or"
> > -                       " ETH_VLAN_FILTER_EXTEND");
> > +   (mask & ETH_VLAN_EXTEND_OFFLOAD))
> > +       RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
> > +                       " ETH_VLAN_EXTEND_OFFLOAD");
> >
>
> Looks good to me, thank you.
>
> Olivier
>