[dpdk-dev] [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype option
Tan, Jianfeng
jianfeng.tan at intel.com
Tue Jan 17 06:23:58 CET 2017
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Tuesday, January 17, 2017 1:16 PM
> To: Tan, Jianfeng
> Cc: dev at dpdk.org; stephen at networkplumber.org; Yao, Lei A
> Subject: Re: [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype
> option
>
> On Mon, Jan 16, 2017 at 02:47:01PM +0000, Jianfeng Tan wrote:
> > +#if (APP_LOOKUP_METHOD == APP_LOOKUP_LPM)
> > + if (ptype_l3_ipv4)
> > +#else
> > + // APP_LOOKUP_EXACT_MATCH
>
> No c++ comment.
OK.
>
> Besides, this patchset misses the release note. Also bear in mind I
> think this feature deserves a howto doc.
Sorry, I missed that in my stash. Will send a new version with fixing Stephen's comment.
Thanks,
Jianfeng
>
> --yliu
More information about the dev
mailing list