[dpdk-dev] [PATCH v7 9/9] eal: enable hotplugging of devices on bus

[Shreyansh Jain]

Hi Ferruh,

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Tuesday, January 17, 2017 4:18 PM
> To: Shreyansh Jain <shreyansh.jain at nxp.com>; david.marchand at 6wind.com
> Cc: dev at dpdk.org; thomas.monjalon at 6wind.com
> Subject: Re: [dpdk-dev] [PATCH v7 9/9] eal: enable hotplugging of devices on
> bus
> 
> On 1/17/2017 10:09 AM, Shreyansh Jain wrote:
> > Given a bus, attach and detach callbacks allow the implementation to
> > handles calls from EAL for attaching or detaching a named device.
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
> 
> <...>
> 
> > +/**
> > + * Search and detach a PCI device from PCI Bus
> > + * Implements rte_bus->detach
> > + *
> > + * @param device_name
> > + *	Name of the device to search and detach
> > + *
> > + * @return
> > + *	0 for successful detaching of device
> > + *	>0 if device not found on bus
> > + *	<0 in case of error in removal.
> 
> These are the return values expected by rte_eal_dev_detach(), but
> rte_eal_pci_detach() is not following these right now, which is causing
> failure on detaching virtual devices.
> 
> Fix is not complex, it may be an option to fix this as a separate patch
> after this patchset applied.

Ok. I will have a look and fix it.
If possible I will push v8; keeping it pending is lower preference for me.

> 
> > + */
> > +int
> > +rte_eal_pci_detach(const char *device_name);
> > +
> > +/**
> 
> <...>