[dpdk-dev] [PATCH] devtools: check stable tag in fixes
yuanhan.liu at linux.intel.com
Wed Jan 18 09:54:34 CET 2017
On Wed, Jan 18, 2017 at 09:32:22AM +0100, Thomas Monjalon wrote:
> > Yes, it's just part of the committer job, say, adding Tested-by,
> > Reviewed-by, that kind of stuff.
> So it should be stressed in the contribution guide that it is the
> responsibility of the author and the maintainer to put this Cc: tag.
Yes, I will do that.
> > > > Last thing, if this tag will remain in the commit log, is this only for
> > > > stable tree, or any "Cc: <mail_address>" can stay in the history?
> > >
> > > I do not see the benefit of keeping other Cc in the history.
> > Again, I really don't know why you bother to remove it, manually, commit
> > by commit. What's the gain here? It just adds more burden to a committer.
> > Honestly, I never do that.
> I had the personal feeling that if the Cc: person is not in SoB, Ack or
> Review tags, it means he's not interested in this patch.
> After thinking more, I was probably wrong.
It's just not commonly used in DPDK, just like people here seldom use
Reviewed-by while everyone just throw an Acked-by.
> > It actually has benefits. Keeping the cc tags allows us to cc them when
> > we find a bug in that patch and make a fix patch later: they are likely
> > to want to know any follow updates on that original patch.
> > It also helps when I send out a stable patch review: I send a copy to
> > all guys on the Cc list, on the Ack/Review, SoB list. I think they might
> > also want to know that patch is a candidate for a specific branch. He may
> > even give some comments, something like "if you pick this one, you might
> > want to pick another one", or "why bother to port it to a stable release",
> > that kind of thing.
> OK Yuanhan, thanks for the explanations.
Thanks for "listening"! :)
> I will send a v2 to relax the constraint of blank line below Fixes: tag,
> and change the warning when Cc: tag is missing. Or remove the warning?
> What do you think of: "Reminder: is it a candidate for stable at dpdk.org backport?"
Yes, I think such Reminder is enough. It might put him thinking more.
More information about the dev