[dpdk-dev] [PATCH v9 01/12] eal/bus: introduce bus abstraction

Shreyansh Jain shreyansh.jain at nxp.com
Wed Jan 18 11:52:19 CET 2017


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, January 18, 2017 4:16 PM
> To: Shreyansh Jain <shreyansh.jain at nxp.com>
> Cc: dev at dpdk.org
> Subject: Re: [PATCH v9 01/12] eal/bus: introduce bus abstraction
> 
> 2017-01-18 16:07, Shreyansh Jain:
> > +void
> > +rte_bus_register(struct rte_bus *bus)
> > +{
> > +	RTE_VERIFY(bus);
> > +	RTE_VERIFY(bus->name && strlen(bus->name));
> > +
> > +	TAILQ_INSERT_TAIL(&rte_bus_list, bus, next);
> > +	RTE_LOG(DEBUG, EAL, "Registered [%s] bus.\n", bus->name);
> > +}
> > +
> > +void
> > +rte_bus_unregister(struct rte_bus *bus)
> > +{
> > +	TAILQ_REMOVE(&rte_bus_list, bus, next);
> > +	RTE_LOG(INFO, EAL, "Unregistered [%s] bus.\n", bus->name);
> > +}
> 
> This log should be DEBUG, consistently with "register" one.
 
:(
Obvious miss.
I will change it.

> 
> > +DPDK_17.02 {
> > +	global:
> > +
> > +	rte_bus_list;
> 
> So finally, is it an useful symbol?
> Could it be removed from this patch?

It is required until test_bus is re-written.
I can move this to next patch (which introduces test_bus).


More information about the dev mailing list