[dpdk-dev] [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name

[Tan, Jianfeng]

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Thursday, January 19, 2017 4:16 PM
> To: Tan, Jianfeng
> Cc: Yigit, Ferruh; dev at dpdk.org; stable at dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix missing driver name
> 
> On Thu, Jan 19, 2017 at 09:16:58AM +0800, Tan, Jianfeng wrote:
> > > >> On 1/18/2017 11:44 AM, Jianfeng Tan wrote:
> > > >>> API rte_eth_dev_info_get() fills driver name according to drv_name
> > > >>> of rte_eth_dev_data. But we have not fill such info in virtio_user.
> > > >>>
> > > >>> We do not use the same one with virtio device as some applications
> > > >>> might depend on driver name to differetiate kinds of devices, such
> > > >>> as VPP.
> > > >>>
> > > >>> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> > > >>> CC: stable at dpdk.org
> > > >>>
> > > >>> Signed-off-by: Jianfeng Tan <jianfeng.tan at intel.com>
> > > >>> ---
> > > >>>  drivers/net/virtio/virtio_user_ethdev.c | 1 +
> > > >>>  1 file changed, 1 insertion(+)
> > > >>>
> > > >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> > > >> b/drivers/net/virtio/virtio_user_ethdev.c
> > > >>> index c877968..110f6a9 100644
> > > >>> --- a/drivers/net/virtio/virtio_user_ethdev.c
> > > >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > > >>> @@ -312,6 +312,7 @@ virtio_user_eth_dev_alloc(const char *name)
> > > >>>  	hw->use_simple_rxtx = 0;
> > > >>>  	hw->virtio_user_dev = dev;
> > > >>>  	data->dev_private = hw;
> > > >>> +	data->drv_name = "virtio_user PMD";
> > > >>
> > > >> How driver naming done changed in next-net.
> > > >> Please check any other virtual driver in next-net for sample.
> > > >
> > > > Thank you for the info. And it seems that it's already fixed by that patch.
> > >
> > > That patch modified during merge, can you please confirm the latest
> > > version in the repo?
> >
> > Just checked latest master repo, this problem has been fixed by commit
> 73db5badb04 ("net: align ethdev and eal driver names"). Thanks to David
> Marchand.
> >
> > Yuanhan, do you think this patch can be applied to the stable repo?
> 
> I think I would partially backport that commit to a stable release: just
> pick the virtio changes, with a brand new commit log, stating the issue
> need to be fixed and it's a partial backport from 73db5badb04 ("net: align
> ethdev and eal driver names").
> 
> Okay to you?

That will be great. Actually, I'm wondering if possible to make your work easier by just adding another very simple fix only to stable branch.

Thanks,
Jianfeng

> 
> 	--yliu