[dpdk-dev] [PATCH] ethdev: fix wrong memset

Yuanhan Liu yuanhan.liu at linux.intel.com
Fri Jan 20 11:34:28 CET 2017

On Fri, Jan 20, 2017 at 11:20:06AM +0100, Thomas Monjalon wrote:
> 2017-01-20 16:04, Yuanhan Liu:
> > Fix an silly error by auto-complete while managing the merge conflicts.
> > It's the eth_dev_data (but not eth_dev) entry should be memset.
> > 
> > Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model")
> You should describe the impact on this bug.

Honestly, I don't know. I didn't met any issue while testing vhost.
Maybe Ferruh knows what might be wrong, since it's him spotted this

> It will be helpful for those testing the RC1.
> > -	memset(&rte_eth_devices[port_id], 0, sizeof(*eth_dev->data));
> > +	memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data));
> The title should be contain the scope of the bug.
> I suggest "fix data reset when allocating port".

Yeah, that's better. Thanks.


More information about the dev mailing list