[dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes
Remy Horton
remy.horton at intel.com
Tue Jan 24 09:16:29 CET 2017
On 20/01/2017 18:37, Thomas Monjalon wrote:
[..]
> 3 comments here:
> - it is in the wrong section (EAL instead of Drivers)
> - secondary processes can setup a vdev PMD
> - before Yuanhan's patch, even PCI PMD were blanking primary process data
Since the code being changed is in rte_ether rather than drivers/net it
seemed the logical place to me.. :)
> I propose this rebase:
>
> - memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data));
> eth_dev = eth_dev_get(port_id);
> + if (rte_eal_process_type() == RTE_PROC_PRIMARY)
> + memset(eth_dev->data, 0, sizeof(*eth_dev->data));
> snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name);
> eth_dev->data->port_id = port_id;
> eth_dev->data->mtu = ETHER_MTU;
Seems OK to me, assuming Yuanhan's patch is going in as-is.
..Remy
More information about the dev
mailing list