[dpdk-dev] [PATCH] mk: fix build of assembly files for ARM64
thomas.monjalon at 6wind.com
Fri Jan 27 17:20:01 CET 2017
2017-01-18 12:31, Zbigniew Bodek:
> On 17.01.2017 23:45, Thomas Monjalon wrote:
> > 2017-01-17 15:35, zbigniew.bodek at caviumnetworks.com:
> >> -# for now, we don't use as but nasm.
> >> -# AS = $(CROSS)as
> > It looks to be a very very old comment.
> >> +ifeq ($(CONFIG_RTE_ARCH_X86),y)
> >> AS = nasm
> > There is no asm file in DPDK as far as I know.
> > So why would we have a dependency on nasm for x86?
> Yes, there is no such file now. We were to add assembly code but
> eventually we decided to put it in a separate library. Nevertheless this
> fix should be harmless if there is no ASM file and will behave correctly
> if someone will add ASM file in the future.
Please remove the ifeq and keep only $(CROSS)as as below.
> >> +else
> >> +AS = $(CROSS)as
> >> +endif
More information about the dev