[dpdk-dev] [PATCH 14/25] eal: do not panic on tailq init

Stephen Hemminger stephen at networkplumber.org
Fri Jan 27 17:30:47 CET 2017


On Fri, 27 Jan 2017 09:56:52 -0500
Aaron Conole <aconole at redhat.com> wrote:

> +			/* no need to TAILQ_REMOVE, we are going to disallow re-attemtps
> +			 * for rte_eal_init().  */

Please put multi-line comments in form:
             /*
              * this is a long comment
              * because there really is lots to say
              */

In many cases, having shorter comment is the best way to handle these.
Often developer writes long comment for themselves because what ever problem
they saw was urgent. Then comment becomes irrelevant later.

             /* TAILQ_REMOVE not needed, error is already fatal */


More information about the dev mailing list