[dpdk-dev] [PATCH] vhost: remove unneeded variable assignment

Yuanhan Liu yuanhan.liu at linux.intel.com
Mon Jan 30 13:47:13 CET 2017


On Tue, Jan 24, 2017 at 09:31:29PM +0100, Emmanuel Roullit wrote:
> Found with clang static analysis:
> lib/librte_vhost/vhost_user.c:996:3: warning:
> Value stored to 'ret' is never read
>         ret = vhost_user_get_vring_base(dev, &msg.payload.state);
>         ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 73c8f9f69c6c ("vhost: introduce reply ack feature")

Again, you were referencing the bad commit. For this case, I'd like to
remove such fixline, as this patch doesn't really "fix" anything. But
since you made it, I could apply it.

So applied to dpdk-next-virtio.

	--yliu


More information about the dev mailing list