[dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor

Ferruh Yigit ferruh.yigit at intel.com
Mon Jan 30 22:23:17 CET 2017


On 1/30/2017 8:57 PM, Wiles, Keith wrote:
> 
>> On Jan 30, 2017, at 2:54 PM, Yigit, Ferruh <ferruh.yigit at intel.com> wrote:
>>
>> From: Keith Wiles <keith.wiles at intel.com>
>>
>> Rx and Tx queues share the common tap file descriptor, but save this
>> value separately.
>>
>> Setting up Rx/Tx queue sets up both queues, release_queue close the
>> tap file but update file descriptor only for that queue.
>>
>> This makes other queue's file descriptor invalid.
>>
>> As a workaround, prevent release_queue callback to be called by default.
>>
>> This is done by separating Rx/Tx setup functions, so that each only
>> setup its own queue, this prevents rte_eth_rx/tx_queue_setup() calling
>> release_queue before setup_queue.
>>
>> Signed-off-by: Keith Wiles <keith.wiles at intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>

Applied to dpdk-next-net/master, thanks.

(Just a reminder, defect still exists when app call
rte_eth_rx/tx_queue_setup() multiple times)



More information about the dev mailing list