[dpdk-dev] [PATCH 2/6] net/tap: use correct channel for error logs
Wiles, Keith
keith.wiles at intel.com
Tue Jan 31 18:04:48 CET 2017
> On Jan 31, 2017, at 10:58 AM, Stephen Hemminger <stephen at networkplumber.org> wrote:
>
> On Tue, 31 Jan 2017 13:07:37 +0000
> Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>
>> On 1/31/2017 9:42 AM, Pascal Mazon wrote:
>>> Signed-off-by: Pascal Mazon <pascal.mazon at 6wind.com>
>>> ---
>>
>> looks good to me.
>>
>
> Agreed, almost all uses of INFO as log level are wrong!
> Either the message is reporting a problem should be NOTICE, WARN, ERR
> or the message is often just developer checking the code and should be DEBUG.
I had already updated most of the logs even before Pascal sent he patch.
Regards,
Keith
More information about the dev
mailing list