[dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc

Mcnamara, John john.mcnamara at intel.com
Sun Jul 2 21:19:20 CEST 2017


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Sunday, July 2, 2017 6:49 PM
> To: Mcnamara, John <john.mcnamara at intel.com>
> Cc: dev at dpdk.org; Rao, Nikhil <nikhil.rao at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc
> 
> 30/06/2017 16:47, Mcnamara, John:
> > >
> > > This patch fixes a typo in the eth device API doc, device config.
> > > not stored between calls to rte_eth_dev_start/stop() should be
> > > restored before a call to rte_eth_dev_start() instead of after a
> > > call to rte_eth_dev_start().
> > >
> > > Signed-off-by: Nikhil Rao <nikhil.rao at intel.com>
> >
> > Acked-by: John McNamara <john.mcnamara at intel.com>
> 
> I am still not convinced by this whole text, but applied to move forward.

Agreed. We should mark this as a defect and have someone re-evaluate the
overall text. However, in terms of this patch, at least it is less wrong than
the existing text.



More information about the dev mailing list