[dpdk-dev] rte_ctrlmbuf_init() and CTRL_MBUF_FLAG are not used - shouldn't they be removed and deprecated ?

[Olivier Matz]

Hi,

On Mon, 3 Jul 2017 06:51:51 +0300, Kevin Wilson <wkevils at gmail.com> wrote:
> Hello,
> With the most recent master tree we have:
> 
> git grep  rte_ctrlmbuf_init
> doc/guides/prog_guide/mbuf_lib.rst:The rte_pktmbuf_init() and
> rte_ctrlmbuf_init() functions initialize some fields in the mbuf
> structure that
> lib/librte_mbuf/rte_mbuf.c:rte_ctrlmbuf_init(struct rte_mempool *mp,
> lib/librte_mbuf/rte_mbuf.h:void rte_ctrlmbuf_init(struct rte_mempool
> *mp, void *opaque_arg,
> lib/librte_mbuf/rte_mbuf_version.map:   rte_ctrlmbuf_init;
> 
> git grep  rte_is_ctrlmbuf
> lib/librte_mbuf/rte_mbuf.h:rte_is_ctrlmbuf(struct rte_mbuf *m)
> 
> git grep CTRL_MBUF_FLAG
> doc/guides/prog_guide/mbuf_lib.rst:or generic control buffers
> (indicated by the CTRL_MBUF_FLAG).
> lib/librte_mbuf/rte_mbuf.c:     m->ol_flags |= CTRL_MBUF_FLAG;
> lib/librte_mbuf/rte_mbuf.h:#define CTRL_MBUF_FLAG       (1ULL << 63)
> /**< Mbuf contains control data */
> lib/librte_mbuf/rte_mbuf.h:     return !!(m->ol_flags & CTRL_MBUF_FLAG);
> 
> rte_ctrlmbuf_init() and CTRL_MBUF_FLAG and rte_is_ctrlmbuf() are not
> used - shouldn't they be removed and deprecated ?

Yes, I'm in favor of removing it since a long time. This was
discussed and partially removed in 2014, because there was still a
user of it in examples/. But it looks that it's now unused since 2015.

Let's see if someone complains, and if no, we can plan to remove it
for 17.11.

Olivier