[dpdk-dev] [PATCH 2/3] vhost: check return values of pthread_* calls
Jens Freimann
jfreimann at redhat.com
Tue Jul 4 11:28:41 CEST 2017
On Tue, Jul 04, 2017 at 05:17:28PM +0800, Yuanhan Liu wrote:
>On Tue, Jul 04, 2017 at 10:50:42AM +0200, Jens Freimann wrote:
>> +out_mutex:
>> + if (pthread_mutex_destroy(&vsocket->conn_mutex))
>> + RTE_LOG(ERR, VHOST_CONFIG,
>> + "error: failed to destroy connection mutex\n");
>
>One minor comment though: {} should be used for one signle statement
>spawning more than one lines. See section "1.6.2. Control Statements
>and Loops":
>
> http://dpdk.org/doc/guides/contributing/coding_style.html
Sorry, checkpatch didn't complain. I'll make sure to add the
parentheses in the future.
>Anyway, I fixed while apply.
Thanks!
regards,
Jens
More information about the dev
mailing list