[dpdk-dev] [PATCH v7 1/6] bus: fix driver registration

Shreyansh Jain shreyansh.jain at nxp.com
Wed Jul 5 15:03:49 CEST 2017


On Wednesday 05 July 2017 05:25 AM, Gaetan Rivet wrote:
> From: Thomas Monjalon <thomas at monjalon.net>
> 
> The bus name was stored with embedded double quotes.
> Indeed the bus name is given with a string in a macro,
> which is not used elsewhere.
> These macros are useless because the buses are drivers,
> so they must not have any API for the application writer.
> The registration can be done with a hardcoded value without quotes.
> 
> There is another (small) benefit of not using macros for driver names:
> it is to have a meaningful constructor function name.
> For instance, it was businitfn_PCI_BUS_NAME instead of businitfn_pci.
> 
> The bus registration macro is also changed to use
> the new RTE_INIT_PRIO macro, similar to RTE_INIT used for other drivers.
> The priority is the highest (101) in order to be sure that the bus driver
> is registered before its device drivers.
> 
> Fixes: 0fd1a0eaae19 ("pci: add bus driver")
> Fixes: fea892e35f21 ("bus/vdev: use standard bus registration")
> Fixes: 7e7df6d0a41d ("bus/fslmc: introduce fsl-mc bus driver")
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> ---

Though I had already acked it in v6,
(from DPAA2 (bus/fslmc) perspective, as well as generically):

Acked-by: Shreyansh Jain <shreyansh.jain at nxp.com>

-
Shreyansh


More information about the dev mailing list