[dpdk-dev] [PATCH v8 1/4] app/testpmd: add isolated mode parameter

Vasily Philipov vasilyf at mellanox.com
Thu Jul 6 08:03:05 CEST 2017


Yes sure, I will send it

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
> Sent: Wednesday, July 05, 2017 18:32
> To: Vasily Philipov <vasilyf at mellanox.com>; dev at dpdk.org
> Cc: Adrien Mazarguil <adrien.mazarguil at 6wind.com>; Nélio Laranjeiro
> <nelio.laranjeiro at 6wind.com>
> Subject: Re: [dpdk-dev] [PATCH v8 1/4] app/testpmd: add isolated mode
> parameter
> 
> On 7/5/2017 4:18 PM, Ferruh Yigit wrote:
> > On 7/5/2017 9:14 AM, Vasily Philipov wrote:
> >> Providing this parameter requests flow API isolated mode on all ports
> >> at initialization time. It ensures all traffic is received through
> >> the configured flow rules only (see flow command).
> >>
> >> Ports that do not support this mode are automatically discarded.
> >>
> >> Signed-off-by: Vasily Philipov <vasilyf at mellanox.com>
> >> ---
> >>  app/test-pmd/parameters.c |  3 +++
> >>  app/test-pmd/testpmd.c    | 14 ++++++++++++++
> >>  app/test-pmd/testpmd.h    |  1 +
> >>  3 files changed, 18 insertions(+)
> >>
> >> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> >> index fbe6284..e313871 100644
> >> --- a/app/test-pmd/parameters.c
> >> +++ b/app/test-pmd/parameters.c
> >> @@ -623,6 +623,7 @@
> >>  		{ "tx-queue-stats-mapping",	1, 0, 0 },
> >>  		{ "rx-queue-stats-mapping",	1, 0, 0 },
> >>  		{ "no-flush-rx",	0, 0, 0 },
> >> +		{ "isolated-mode",	        0, 0, 0 },
> >
> > Can you please document the new option [1] ?
> >
> > And when you don't know nothing about isolated-mode, this option is
> > not specific enough. What do you think adding a "flow" or similar
> > keyword to the option?
> >
> > [1]
> > doc/guides/testpmd_app_ug/run_app.rst
> 
> Overall this testpmd patch seems can be seperated from patchset.
> 
> I will check other driver patches in the patchset, can you please send new
> version of this patch as a standalone patch?
> 
> Thanks,
> ferruh


More information about the dev mailing list