[dpdk-dev] [PATCH 00/19] cleanup duplicate includes

Stephen Hemminger stephen at networkplumber.org
Tue Jul 11 20:55:27 CEST 2017


Using a simple script (in first patch), discovered that there was
lots of #include file sloppiness in DPDK.  This patch series
fixes everything but base drivers and examples.

Stephen Hemminger (19):
  devtools: add simple script to find duplicate includes
  eal: remove duplicate includes
  cmdline: remove duplicate include of errno.h
  distributor: remove duplicate include of rte_compat.h
  lpm: remove duplicate include of errno.h
  cuckoo_hash: remove duplicate include of rte_log.h
  timer: remove duplicate include of rte_per_lcore.h
  bnxt: remove duplicate include of unistd.h
  ixgbe: remove duplicate include of rte_atomic.h
  i40e: remove duplicate include of rte_atomic.h
  virtio: remove duplicated includes
  cxgbe: remove duplicated includes
  vmxnet3: remove duplicated include of rte_atomic.h
  dpaa2: remove duplicated includes
  fsmlc: remove duplicated includes
  app/proc-info: remove duplicate include
  app/test-pmd: remove duplicate includes
  test/test-pipeline: remove duplicate include of rte_per_lcore.h
  test/test: remove duplicate includes

 app/proc_info/main.c                             |  1 -
 app/test-pmd/cmdline.c                           |  1 -
 app/test-pmd/config.c                            |  1 -
 app/test-pmd/csumonly.c                          |  2 -
 app/test-pmd/flowgen.c                           |  1 -
 app/test-pmd/iofwd.c                             |  1 -
 app/test-pmd/macfwd.c                            |  1 -
 app/test-pmd/macswap.c                           |  1 -
 app/test-pmd/parameters.c                        |  1 -
 app/test-pmd/rxonly.c                            |  1 -
 app/test-pmd/txonly.c                            |  2 -
 devtools/dup_include.pl                          | 64 ++++++++++++++++++++++++
 drivers/bus/fslmc/fslmc_vfio.c                   |  2 -
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c         |  1 -
 drivers/event/dpaa2/dpaa2_eventdev.c             |  1 -
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c         |  1 -
 drivers/net/bnxt/bnxt_hwrm.c                     |  2 -
 drivers/net/cxgbe/cxgbe_ethdev.c                 |  1 -
 drivers/net/cxgbe/cxgbe_main.c                   |  1 -
 drivers/net/cxgbe/sge.c                          |  1 -
 drivers/net/dpaa2/dpaa2_ethdev.c                 |  1 -
 drivers/net/dpaa2/dpaa2_rxtx.c                   |  1 -
 drivers/net/i40e/i40e_ethdev_vf.c                |  1 -
 drivers/net/ixgbe/ixgbe_ethdev.c                 |  1 -
 drivers/net/ixgbe/ixgbe_flow.c                   |  1 -
 drivers/net/virtio/virtio_user/virtio_user_dev.c |  1 -
 drivers/net/virtio/virtio_user_ethdev.c          |  1 -
 drivers/net/vmxnet3/vmxnet3_ethdev.c             |  1 -
 lib/librte_cmdline/cmdline_parse_etheraddr.c     |  1 -
 lib/librte_distributor/rte_distributor.c         |  1 -
 lib/librte_eal/bsdapp/eal/eal.c                  |  2 -
 lib/librte_eal/bsdapp/eal/eal_pci.c              |  2 -
 lib/librte_eal/bsdapp/eal/eal_thread.c           |  1 -
 lib/librte_eal/common/eal_common_dev.c           |  1 -
 lib/librte_eal/common/eal_common_tailqs.c        |  1 -
 lib/librte_eal/common/rte_keepalive.c            |  1 -
 lib/librte_eal/linuxapp/eal/eal.c                |  2 -
 lib/librte_eal/linuxapp/eal/eal_memory.c         |  2 -
 lib/librte_eal/linuxapp/eal/eal_thread.c         |  1 -
 lib/librte_eal/linuxapp/eal/eal_xen_memory.c     |  2 -
 lib/librte_hash/rte_cuckoo_hash.c                |  1 -
 lib/librte_lpm/rte_lpm.c                         |  1 -
 lib/librte_lpm/rte_lpm6.c                        |  1 -
 lib/librte_timer/rte_timer.c                     |  1 -
 test/test-pipeline/config.c                      |  1 -
 test/test-pipeline/init.c                        |  1 -
 test/test-pipeline/main.c                        |  1 -
 test/test-pipeline/runtime.c                     |  2 -
 test/test/test_alarm.c                           |  1 -
 test/test/test_atomic.c                          |  1 -
 test/test/test_eal_flags.c                       |  1 -
 test/test/test_malloc.c                          |  1 -
 test/test/test_mbuf.c                            |  1 -
 test/test/test_mp_secondary.c                    |  4 --
 test/test/test_per_lcore.c                       |  1 -
 test/test/test_ring.c                            |  1 -
 test/test/test_rwlock.c                          |  1 -
 test/test/test_spinlock.c                        |  1 -
 58 files changed, 64 insertions(+), 70 deletions(-)
 create mode 100755 devtools/dup_include.pl

-- 
2.11.0



More information about the dev mailing list