[dpdk-dev] [PATCH] net/sfc: add support for xstats retrieval by ID

Remy Horton remy.horton at intel.com
Wed Jul 12 16:18:42 CEST 2017


On 08/07/2017 16:45, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov at oktetlabs.ru>
>
> Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
[..]

Reviewed-by: Remy Horton <remy.horton at intel.com>


> +	rc = sfc_port_update_mac_stats(sa);
> +	if (rc != 0) {
> +		SFC_ASSERT(rc > 0);
> +		ret = -rc;

sfc_port_update_mac_stats() really ought to be returning -EINVAL or 
-ENOMEM rather than EINVAL/ENOMEM then doing a negation here.

Other than that, code seems OK..


More information about the dev mailing list