[dpdk-dev] [PATCH] ethdev: fix build with gcc 5.4.0

Thomas Monjalon thomas at monjalon.net
Thu Jul 13 11:35:58 CEST 2017


06/07/2017 23:45, Thomas Monjalon:
> Seen on Ubuntu 16.04 with GCC 5.4.0:
> 
> lib/librte_ether/rte_ethdev.c: In function 'get_mac_addr_index':
> lib/librte_ether/rte_ethdev.c:2369:26: error:
> 'dev_info.max_mac_addrs' may be used uninitialized in this function
> 
> Indeed, rte_eth_dev_info_get() do not write into dev_info
> if the port_id is not valid.
> So we need to check the port_id and return in case of error.
> 
> This extra check should not be needed because the port_id is always
> checked before calling get_mac_addr_index().
> However it does not hurt.
> 
> Reported-by: Matan Azrad <matan at mellanox.com>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> Tested-by: Matan Azrad <matan at mellanox.com>

Applied


More information about the dev mailing list