[dpdk-dev] [PATCH v2] cryptodev: fix KASUMI F9 expected parameters

[Trahe, Fiona]

Hi Pablo,

> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, July 14, 2017 4:48 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Doherty, Declan
> <declan.doherty at intel.com>; Jain, Deepak K <deepak.k.jain at intel.com>; Griffin, John
> <john.griffin at intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com>
> Cc: dev at dpdk.org
> Subject: RE: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters
> 
> 
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Friday, July 14, 2017 8:07 AM
> > To: Doherty, Declan <declan.doherty at intel.com>; Trahe, Fiona <fiona.trahe at intel.com>; Jain, Deepak
> K
> > <deepak.k.jain at intel.com>; Griffin, John <john.griffin at intel.com>; Kusztal, ArkadiuszX
> > <arkadiuszx.kusztal at intel.com>
> > Cc: dev at dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> > Subject: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters
> >
> > For KASUMI F9 algorithm, COUNT, FRESH and DIRECTION
> > input values need to be contiguous with
> > the message, as described in the KASUMI and QAT PMD
> > documentation.
> >
> > Before, the COUNT and FRESH values were set
> > as part of the AAD (now IV), but always set before
> > the beginning of the message.
> > Since now the IV is set after the crypto operation,
> > it is not possible to have these values in the
> > expected location.
> >
> > Therefore, as these are required to be contiguous,
> > cryptodev API will expect these them to be passed
> > as a single buffer, already constructed, so
> > authentication IV parameters not needed anymore.
> >
> > Fixes: 681f540da52b ("cryptodev: do not use AAD in wireless algorithms")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> Acked-by: Fiona Trahe <fiona.trahe at intel.com>

The limitation in QAT documentation stating that Kasumi F9 auth_len and auth_offset must be byte-multiples can be removed as this is now a limitation on the API, not on QAT.