[dpdk-dev] [PATCH v10 03/11] net/failsafe: add fail-safe PMD

[Gaëtan Rivet]

On Mon, Jul 17, 2017 at 02:56:54PM +0100, Ferruh Yigit wrote:

<...>

> > +Stats per queue      = Y
> > +Unicast MAC filter   = Y
> > +Queue start/stop     = Y
> > +Jumbo frame          = Y
> > +Multicast MAC filter = Y
> 
> Is above ones supported by PMD, I don't see them unless I miss something.
> 

Queue start/stop was an error.
All others are supported as long as the slave support it.

<...>

> > +		sdev = TX_SUBDEV(dev);
> > +		rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos);
> > +		PRIV(dev)->infos.rx_offload_capa = rx_offload_capa;
> 
> Is intention &= ?
> 

rx_offload_capa is already set a little higher, and then an AND is done
on it with all slaves. The "=" is correct here. Thanks for asking
though, it's always useful to check :).

---

I fixed all other remarks. I will wait a little for any possible
additional changes you might want to point before sending the new
version.

-- 
Gaëtan Rivet
6WIND