[dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API

[De Lara Guarch, Pablo]

HI Yuanhan,

> -----Original Message-----
> From: Yuanhan Liu [mailto:yliu at fridaylinux.org]
> Sent: Tuesday, July 18, 2017 3:39 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> Cc: Akhil Goyal <akhil.goyal at nxp.com>; dev at dpdk.org; stable at dpdk.org;
> hemant.agrawal at nxp.com
> Subject: Re: [PATCH v2] crypto/dpaa2_sec: fix the return of supported API
> 
> On Tue, Jul 18, 2017 at 10:26:39AM +0000, De Lara Guarch, Pablo wrote:
> > Hi Akhil,
> >
> > > -----Original Message-----
> > > From: Akhil Goyal [mailto:akhil.goyal at nxp.com]
> > > Sent: Tuesday, July 18, 2017 8:34 AM
> > > To: dev at dpdk.org; stable at dpdk.org
> > > Cc: hemant.agrawal at nxp.com; De Lara Guarch, Pablo
> > > <pablo.de.lara.guarch at intel.com>; yliu at fridaylinux.org; Akhil Goyal
> > > <akhil.goyal at nxp.com>
> > > Subject: [PATCH v2] crypto/dpaa2_sec: fix the return of supported
> > > API
> > >
> > > call to dpaa2_sec_dev_configure() is made mandatory, but
> > > dpaa2_sec_pmd returns a ENOTSUP which results in device not getting
> configured.
> > >
> > > dpaa2_sec PMD does not need any further configuration to be done in
> > > dpaa2_sec_dev_configure, hence returning 0
> > >
> > > Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations")
> > >
> > > Cc: stable at dpdk.org
> > >
> > > Signed-off-by: Akhil Goyal <akhil.goyal at nxp.com>
> >
> > Looks ok to me, but this is only applicable in the stable branch, so
> > no need to send it to dev at dpdk.org.
> 
> Why? We already have such fix in upstream? Normally, we just pick
> upstream commits (but not patches: the emails) to stable release.

It looks like this fix was included in
13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR").
Unfortunately, this patch should have been split into two different patches.
Since this has already been merged, I think our only way to integrate this
In 17.05.1 is by getting it separately.

Pablo

> 
> 	--yliu