[dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

[Herbert Guan]

Thomas,

Thanks a lot for your review and comment.  But I have some concern in this approach.  "poly128_t" is for ARM64 platform only and in fact it's more likely that rte_v128u8_t (generic DPDK data type) could be defined from poly128_t (ARM data type) which seems more reasonable.

Best regards,
Herbert

-----Original Message-----
From: Thomas Monjalon [mailto:thomas at monjalon.net]
Sent: Tuesday, July 18, 2017 22:44
To: Herbert Guan <Herbert.Guan at arm.com>
Cc: dev at dpdk.org; jianbo.liu at linaro.org; jerin.jacob at caviumnetworks.com; nelio.laranjeiro at 6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

13/07/2017 05:16, Herbert Guan:
> --- a/lib/librte_eal/common/include/arch/arm/rte_vect.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h
> +#if (GCC_VERSION < 40900)
> +typedef uint64_t poly64_t;
> +typedef uint64x2_t poly64x2_t;
> +typedef uint8_t poly128_t __attribute__((vector_size(16), aligned(16)));
> +#endif

I think a better fix would be to switch to DPDK types
like rte_v128u8_t.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.